Intake Feeder Wheel #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbxyz
previously requested changes
Jan 17, 2026
src/main/java/frc/robot/subsystems/intakeFeederwheel/IntakeFeederwheelConfig.java
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/intakeFeederwheel/intakeFeederwheelSubsystem.java
Outdated
Show resolved
Hide resolved
…m and started on robot container (sorry for doing so much in one commit)
Ankit-Panda-2010
requested changes
Jan 17, 2026
Ankit-Panda-2010
left a comment
Ankit-Panda-2010
left a comment
There was a problem hiding this comment.
Try using the VoltageOut as a control request
Ankit-Panda-2010
previously requested changes
Jan 17, 2026
Ankit-Panda-2010
left a comment
Ankit-Panda-2010
left a comment
There was a problem hiding this comment.
Delete the Sim implementation since there's no reason between the Sim and TalonFX Implementation, use an if statement using Robot.isSimulation
samperlmutter
requested changes
Jan 17, 2026
Member
samperlmutter
left a comment
samperlmutter
left a comment
There was a problem hiding this comment.
looks pretty good for the most part. couple small things
src/main/java/frc/robot/subsystems/intakeFeederwheel/IntakeFeederwheelTalonFX.java
Show resolved
Hide resolved
samperlmutter
previously requested changes
Jan 18, 2026
Member
samperlmutter
left a comment
samperlmutter
left a comment
There was a problem hiding this comment.
looks much better. just a couple clean up stuff, then remove the changes to the build and config classes
anishb77
dismissed stale reviews from samperlmutter, Ankit-Panda-2010, and drewbxyz
done
drewbxyz
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of Change
Subsystem(s) Modified
Description of Changes
Additional Context
Checklist
Screenshots/Videos